improvement: Simplify checks

[thyarles]

Just pointing that the && and || on bash are not equivalent to the if ... then ... else, as you can get more details here.

You can simplify the way to save the exit_status from this

COMMAND && exit_status=$? || exit_status=$?

to this

COMMAND ; exit_status=$?

Thanks!

[github-actions]

Thanks for implementing a fix, could you ensure that the test covers your changes.

[thyarles]

Hi @jackton1!

Since last week GitHub started offering a way to clone only the main branch by default. Do you think this could be the reason the test failed?

Thank you!

[jackton1]

@thyarles Yes I believe that’s the problem.

[jackton1]

@all-contributors please add @thyarles for code.

[allcontributors]

@jackton1

I've put up a pull request to add @thyarles! 🎉

[thyarles]

Hi @jackton1,

Thanks for accepting my PR. I have more few improvisations on the bash. Should I do it and suggest as well?

[jacktony1]

Hi @thyarles, Sure you can create a new Pull Request and I'll be happy to review it.