Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changes since Last commit on the branch brings all files since the beggining of the branch #2065

Closed
4 tasks done
iamtheef opened this issue Apr 26, 2024 · 5 comments
Closed
4 tasks done
Labels

Comments

@iamtheef
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

I am using the tool as documented but I still get all the files that were changed since the branch started

To Reproduce

  - name: Get changed files
    id: changed-files
    uses: tj-actions/changed-files@v44
    # To compare changes between the current commit and the last pushed remote commit set `since_last_remote_commit: true`. e.g
    with:
      since_last_remote_commit: "true"
  
  - name: List all changed files
    env:
      ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
    run: |
      for file in ${ALL_CHANGED_FILES}; do
        echo "$file was changed"
      done

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-22.04

Expected behavior?

Only the files since the last commit in the branch

Relevant log output

src/caf/Dockerfile.api was changed
src/caf/Dockerfile.cron was changed
src/hqm/Dockerfile.api was changed
src/hqm/Dockerfile.cron was changed
src/ins/Dockerfile.api was changed
src/ins/Dockerfile.cron was changed
tracetag.sh was changed
.DS_Store was changed
.github/workflows/main.yaml was changed # ONLY THIS WAS CHANGED SINCE LAST COMMIT IN THE BRANCH
.github/workflows/release.yaml was changed
manage.py was changed
src/.DS_Store was changed
src/shared/core/minio.py was changed
src/aco/Dockerfile.api was changed
src/aco/Dockerfile.cron was changed

Has all relevant logs been included?

  • I've included all relevant logs

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@iamtheef iamtheef added the bug Something isn't working label Apr 26, 2024
@tj-actions-bot
Copy link
Contributor

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

@iamtheef
Copy link
Author

Hey, sure!
Let me know when this is patched ;) Glad to use your code

@jackton1
Copy link
Member

jackton1 commented Apr 26, 2024

Hi, @iamtheef there are several missing details required to provide feedback or replicate this issue.

  1. Can you provide the entire log output with debugging enabled, which includes details of the commit hashes compared.
  2. List the relevant commits you have in the PR/Branch where the action was triggered.
  3. Can you also provide more details of the workflow file including the event and checkout action configuration.

@jackton1
Copy link
Member

jackton1 commented Apr 26, 2024

Example

A short example of this is the following logs

Screenshot 2024-04-26 at 3 17 36 PM

Commits compared

9f8502e58178464eefa82a2374eafdb01e016029 (feat/reduce-the-default-fetch-depth) → 22e061a3a53470796bc50dbe1fa9fb6b9973dd27 (feat/reduce-the-default-fetch-depth)

Commits of the branch

Screenshot 2024-04-26 at 3 19 59 PM

@jackton1 jackton1 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
@jackton1
Copy link
Member

Hi @iamtheef I haven't heard back from you, I'll be closing this issue for now pending your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants