Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changed files after pull request merge not working #1550

Closed
4 tasks done
remisalmon opened this issue Sep 8, 2023 · 1 comment · Fixed by #1556
Closed
4 tasks done

[BUG] Changed files after pull request merge not working #1550

remisalmon opened this issue Sep 8, 2023 · 1 comment · Fixed by #1556
Labels
bug Something isn't working

Comments

@remisalmon
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Does this issue exist in the latest version?

  • I'm using the latest release

Describe the bug?

When running the action after a pull request merge to get the list of files changed in the source branch no files are found because the action is comparing the source branch to the merge commit in the target branch.

This is sort of expected since the diff between the target branch and the source branch is null after merging the source branch but according to #874 showing the list of files changed should be possible.

To Reproduce

  1. Setup the action to run when github.event.pull_request.merged == true
  2. Print all_modified_files shows an empty string

Reproduced in https://github.com/remisalmon/test-actions/actions/runs/6124183707/job/16623667321 with this workflow: https://github.com/remisalmon/test-actions/blob/main/.github/workflows/ci.yml and this pull request: remisalmon/test-actions#1.

What OS are you seeing the problem on?

ubuntu-latest or ubuntu-22.04

Expected behavior?

The action should still show the list of changed files between the target branch and source branch after the source branch is merged in the target branch.

Relevant log output

See https://github.com/remisalmon/test-actions/actions/runs/6124183707/job/16623667321

Has all relevant logs been included?

  • I've included all relevant logs

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@remisalmon remisalmon added the bug Something isn't working label Sep 8, 2023
@jackton1 jackton1 linked a pull request Sep 9, 2023 that will close this issue
@jackton1
Copy link
Member

jackton1 commented Sep 9, 2023

Hi @remisalmon, this should be fixed in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants