You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The release of version 1.5.0 revealed some accidental API changes that broke user code. It was suggested that we incorporate Revapi into our build process to compare against previous releases and discover any breaking changes.
Basically the return types of TagCreator were no longer compatible with compiled libraries. I also noticed that some methods are gone, such as withRole() for ATags. I think we've gone past restoring things at this point. But we can at least ensure that this is more easily caught before merges.
Edit:
You can see the full list of errors by changing <artifact>com.j2html:j2html:1.5.0</artifact> to <artifact>com.j2html:j2html:1.4.0</artifact> in the POM for the revapi-maven-plugin. and then running the verify phase.
Yes, probably 1.5.0 should have been 2.0.0.
The generated classes support only those attributes that are allowed per HTML specification, so many (wrongly used) attributes are gone, which is indeed no longer compatible.
Activity
Resolves tipsy#194. Introduces Revapi into the build process.
sembler commentedon Jun 16, 2021
@tipsy can we use the verify goal for actions for this project? Or at least include the Revapi 'check' goal?
Resolves tipsy#194. Introduces Revapi into the build process.
sembler commentedon Jun 17, 2021
Looks like the goal change works as expected. I'll merge unless you have concerns @tipsy , @obecker.
obecker commentedon Jun 17, 2021
Out of curiosity: what were those incompatible changes? Should we restore something?
sembler commentedon Jun 17, 2021
26ba4c3
Basically the return types of TagCreator were no longer compatible with compiled libraries. I also noticed that some methods are gone, such as withRole() for ATags. I think we've gone past restoring things at this point. But we can at least ensure that this is more easily caught before merges.
Edit:
You can see the full list of errors by changing
<artifact>com.j2html:j2html:1.5.0</artifact>
to<artifact>com.j2html:j2html:1.4.0</artifact>
in the POM for the revapi-maven-plugin. and then running the verify phase.obecker commentedon Jun 18, 2021
Yes, probably 1.5.0 should have been 2.0.0.
The generated classes support only those attributes that are allowed per HTML specification, so many (wrongly used) attributes are gone, which is indeed no longer compatible.