Remove the unused EncodingDecoder #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project "encoding" appears to be unmaintained, and hasn't received an update since 2017. Unfortunately the "encoding" artifacts on crates.io do not contain the licenses for the project, which adds difficulty in auditing dependencies. Since "tiny-http" doesn't actually use the EncodingDecoder, this patch removes it and it's dependency on "encoding" in order to avoid complications resolving the "tiny-http" dependency story. Instead, I would suggest investigating migrating over to https://docs.rs/encoding_rs/0.8.13/encoding_rs/, which appears to be actively maintained by Mozilla. If this patch is accepted, would it be possible to get a release as well?
tomaka
approved these changes
Dec 29, 2018
|
Thanks @tomaka! Is there anything that needs to be done for this to land? |
|
bors r+ |
frewsxcv
approved these changes
Jan 5, 2019
bors bot
added a commit
that referenced
this pull request
Jan 5, 2019
153: Remove the unused EncodingDecoder r=frewsxcv a=erickt The project "encoding" appears to be unmaintained, and hasn't received an update since 2017. Unfortunately the "encoding" artifacts on crates.io do not contain the licenses for the project, which adds difficulty in auditing dependencies. Since "tiny-http" doesn't actually use the EncodingDecoder, this patch removes it and it's dependency on "encoding" in order to avoid complications resolving the "tiny-http" dependency story. Instead, I would suggest investigating migrating over to https://docs.rs/encoding_rs/0.8.13/encoding_rs/, which appears to be actively maintained by Mozilla. If this patch is accepted, would it be possible to get a release as well? Co-authored-by: Erick Tryzelaar <etryzelaar@google.com>
Build succeeded |
|
@erickt Just published a new version! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project "encoding" appears to be unmaintained, and hasn't received
an update since 2017. Unfortunately the "encoding" artifacts on
crates.io do not contain the licenses for the project, which adds
difficulty in auditing dependencies.
Since "tiny-http" doesn't actually use the EncodingDecoder, this patch
removes it and it's dependency on "encoding" in order to avoid
complications resolving the "tiny-http" dependency story.
Instead, I would suggest investigating migrating over to
https://docs.rs/encoding_rs/0.8.13/encoding_rs/, which appears to be
actively maintained by Mozilla.
If this patch is accepted, would it be possible to get a release as
well?