Replies: 1 comment
-
I don't remember, sorry |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
There is an empty 10 years old TODO at
tiny-http/src/request.rs
Lines 214 to 217 in e221563
EqualReader
returns in the tuple an unusedReceiver
of ampsc::channel
.To fix an OOM as a side-effect I've changed the API here to provide the
Option<Sender>
as parameter and using None.This is the only usage of
EqualReader
in the project.But maybe @tomaka or anyone else can remember what has been the intention to start thinking about using channel-communication in the drop of
EqualReader
and what maybe could be put after the TODO-colon?Beta Was this translation helpful? Give feedback.
All reactions