From 15fb537bcd86e519b468418b8a7dd9c6e601a419 Mon Sep 17 00:00:00 2001 From: Manuel Mendez Date: Wed, 4 May 2022 16:16:07 -0400 Subject: [PATCH] tink-cli: Ensure opt.RetrieveData is non-nil before invoking Otherwise we get a nice panic. Signed-off-by: Manuel Mendez --- cmd/tink-cli/cmd/get/get.go | 3 +++ cmd/tink-cli/cmd/get/get_test.go | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/cmd/tink-cli/cmd/get/get.go b/cmd/tink-cli/cmd/get/get.go index 5dcb7152a..0c4b8f7d5 100644 --- a/cmd/tink-cli/cmd/get/get.go +++ b/cmd/tink-cli/cmd/get/get.go @@ -67,6 +67,9 @@ func NewGetCommand(opt Options) *cobra.Command { if len(args) != 0 { data, err = retrieveMulti(cmd.Context(), opt, client, args) } else { + if opt.RetrieveData == nil { + return errors.New("get-all-data is not implemented for this resource yet, please have a look at the issue in GitHub or open a new one") + } data, err = opt.RetrieveData(cmd.Context(), client) } if err != nil { diff --git a/cmd/tink-cli/cmd/get/get_test.go b/cmd/tink-cli/cmd/get/get_test.go index a9e3d1c84..d9aa3ecfc 100644 --- a/cmd/tink-cli/cmd/get/get_test.go +++ b/cmd/tink-cli/cmd/get/get_test.go @@ -214,6 +214,10 @@ func TestNewGetCommand(t *testing.T) { }, }, }, + { + Name: "no opts", + ExpectError: errors.New("get-all-data is not implemented for this resource yet, please have a look at the issue in GitHub or open a new one"), + }, } for _, s := range tests {