Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 6.0 #156

Merged
merged 2 commits into from Aug 7, 2019
Merged

Conversation

mediafinger
Copy link
Contributor

@mediafinger mediafinger commented Jul 31, 2019

I updated an app which uses devise and devise-two-factor for TOTP passwords to Rails 6.0.0.rc2 and the only small problem I had while updating was that this gem sets versions of railties and activesupport very restrictively. I don't know if such a defensive limitation is necessary, but I followed the pattern and allowed only compatibility with Rails 6.0.

I tested our app:

  • login with existing 2FA
  • generation of barcode
  • new connection with GA
    • verification of generated OTP
  • backup code generation

and found no issues.

I also didn't see anything in the Rails upgrade which should influence this gem negatively.

--

I also updated the CI matrix:

--

I am aware this is almost a duplicate of PR #153 but I think that my changes to the CI build matrix are preferable.

@bsedat
Copy link
Member

bsedat commented Aug 7, 2019

Thanks!!!

@bsedat bsedat merged commit 10800a1 into devise-two-factor:master Aug 7, 2019
@bsedat bsedat mentioned this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants