Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated an app which uses devise and devise-two-factor for TOTP passwords to Rails 6.0.0.rc2 and the only small problem I had while updating was that this gem sets versions of railties and activesupport very restrictively. I don't know if such a defensive limitation is necessary, but I followed the pattern and allowed only compatibility with Rails 6.0.
I tested our app:
and found no issues.
I also didn't see anything in the Rails upgrade which should influence this gem negatively.
--
I also updated the CI matrix:
gem update --system
to avoid failure with older Ruby versions--
I am aware this is almost a duplicate of PR #153 but I think that my changes to the CI build matrix are preferable.