Fix paranoid-mode being ignored #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devise's paranoid-mode is meant to hide when a record with an e-mail exists in the system, by always showing the invalid error message instead of conditionally revealing when a record is not found. This gem ignores the setting and reveals existing accounts during an enumeration attack.
mkljczk
approved these changes
Nov 30, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devise's paranoid-mode is meant to hide when a record with an e-mail exists in the system, by always showing the invalid error message instead of conditionally revealing when a record is not found. This gem ignores the setting and reveals existing accounts during an enumeration attack.
Impact: Thankfully in most cases the Devise translations for "invalid" and "not_found_in_database" are identical, however, this is not guaranteed, and can easily slip through in a large project with many languages and volunteer translators.