Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0 devel #551

Merged
merged 14 commits into from Aug 30, 2022
Merged

3.0 devel #551

merged 14 commits into from Aug 30, 2022

Conversation

timsneath
Copy link
Contributor

Branch for the 3.0 release.

  • Update CHANGELOG
  • Migrate WinRT code to a separate library that is a superset of the win32 library

@timsneath timsneath marked this pull request as ready for review August 30, 2022 13:18
@timsneath timsneath linked an issue Aug 30, 2022 that may be closed by this pull request
Decide what WinRT classes to feature/include for next release #461
Closed
@timsneath
Copy link
Contributor Author

@halildurmus This is my first stab at a 3.0 release build. PTAL and see if you're happy with this from your side. In particular, feel free to remove additional WinRT classes that are either not ready for primetime or included solely because they're good tests of the generator (XML?)

halildurmus
halildurmus reviewed Aug 30, 2022
View reviewed changes
lib/winrt.dart Outdated Show resolved Hide resolved
@halildurmus
Copy link
Member

@halildurmus This is my first stab at a 3.0 release build. PTAL and see if you're happy with this from your side. In particular, feel free to remove additional WinRT classes that are either not ready for primetime or included solely because they're good tests of the generator (XML?)

This looks great! I'll take a look.

halildurmus
halildurmus approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@halildurmus halildurmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I also pushed some commits. Could you take a look?

@timsneath
Copy link
Contributor Author

This all looks good. I've run through a bunch of tests, and have also tried a couple of other packages to make sure that the only breaking changes are to COM/WinRT. I'll aim to push this live if the CI completes successfully.

@timsneath timsneath merged commit 777c608 into main Aug 30, 2022
@timsneath timsneath deleted the 3.0-devel branch August 30, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halildurmus halildurmus halildurmus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decide what WinRT classes to feature/include for next release
2 participants
@timsneath @halildurmus