Extra newline before comment with -n --fss, 5.0.5+ regression

[scop]

isort 5.0.5 and later (up to 5.0.9) adds a spurious newline before a comment in the following scenario with -n --fss:

$ cat t.py
import sys

# Comment canary
from . import foo
$ isort -n --fss t.py 
Fixing /tmp/t.py
$ cat t.py
import sys


# Comment canary
from . import foo

There shouid be only one newline between import sys and # Comment canary. 5.0.4 and earlier did not have this problem. It is also somehow specific to both -n and --fss being specified; neither alone triggers the issue.

[timothycrosley]

A fix for this has been deployed to PyPI in the 5.1.0 release,

Thanks for reporting!

~Timothy

[scop]

Thanks; that case is fixed indeed but there are some other related ones lurking, see #1322