--keep-direct-and-as options should be removed

[ucodery]

This setting now defaults to True, so there is no point in setting it in the shell. It should be marked deprecated and then removed after a few minor releases.

Additionally, there is no mirror to this option (--discard-direct-with-as if you will), and it is not listed as a configurable setting in the wiki (although the tests suggest that it would work if added to a config). The only sure way to get the old behavior is to use the api directly. For these reasons I would suggest also removing keep_direct_and_as_imports from isort code as a whole. IMHO this setting just has the ability to introduce bugs. The following simple script would break if keep_direct_and_as_imports was set to False, for instance in an upstream commit hook.

from os import path
import os.path as pth

def foo(bar):
    return path.pathsep.join(bar)

[timothycrosley]

Thanks for reporting! This is fixed in develop and slated to be released in the 5.1.0 minor release by the end of the month

[timothycrosley]

A fix for this has been deployed to PyPI in the 5.1.0 release,

Thanks for reporting!

~Timothy