Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isort fails silently if --sp points to an invalid path. and it ignores files not named exactly correctly. #1174

Closed
hjwp opened this issue Apr 6, 2020 · 2 comments
Closed

isort fails silently if --sp points to an invalid path. and it ignores files not named exactly correctly. #1174

hjwp opened this issue Apr 6, 2020 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone
5.1.0

Comments

@hjwp
Copy link

hjwp commented Apr 6, 2020

i spent about an hour wondering why isort wasn't doing what i told it.

  1. -sp /invalid/path produces no errors
  2. -sp /real/path/to/a-file-not-name.isort.cfg also fails silently

rage.gif

(i am not accusing anyone of a moral or professional failure here. i am grateful for a free tool. just sharing my pain, in the hopes that someone else may be spared it)
@timothycrosley timothycrosley added bug Something isn't working documentation Improvements or additions to documentation labels Jul 4, 2020
@timothycrosley timothycrosley added this to the 5.1.0 milestone Jul 4, 2020
timothycrosley added a commit that referenced this issue Jul 12, 2020
@timothycrosley
isort now throws an exception if an invalid settings path is given (i…
db34caa 
…ssue #1174).
@timothycrosley
Copy link
Member

Thanks for reporting! This is fixed in the develop branch and will make it out in the 5.1.0 version of isort.

@timothycrosley
Copy link
Member

This has now been deployed to PyPI in the 5.1.0 release, thanks again!

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
2 participants
@hjwp @timothycrosley