Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont round off floats while formatting #679

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dracarys18
Copy link

Fixes #678

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.7%. Comparing base (4a74924) to head (dacd1e4).
Report is 39 commits behind head on main.

Files Patch % Lines
time/src/formatting/mod.rs 92.9% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #679     +/-   ##
=======================================
- Coverage   97.8%   97.7%   -0.0%     
=======================================
  Files         81      82      +1     
  Lines       9378    9110    -268     
=======================================
- Hits        9169    8905    -264     
+ Misses       209     205      -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -40,6 +41,31 @@ const WEEKDAY_NAMES: [&[u8]; 7] = [
b"Sunday",
];

/// Wrapper struct for f64 with custom Display formatter
#[derive(Debug, Clone, Copy)]
pub struct FloatNum(f64);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this public for tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting bug on ISO8601
1 participant