Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nicer Debug implementations #509

Merged
merged 1 commit into from Oct 3, 2022
Merged

Use nicer Debug implementations #509

merged 1 commit into from Oct 3, 2022

Conversation

xy2i
Copy link
Contributor

@xy2i xy2i commented Sep 24, 2022

Same as Display for now

Closes #503.

@jhpratt jhpratt added the C-keep-open Category: should not be closed due to inactivity label Sep 25, 2022
@jhpratt jhpratt self-requested a review September 25, 2022 03:58
@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #509 (8f9fa6b) into main (d0bab6a) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

❗ Current head 8f9fa6b differs from pull request most recent head 25e118f. Consider uploading reports for the commit 25e118f to get more accurate results

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   99.42%   99.04%   -0.39%     
==========================================
  Files          70       70              
  Lines        7186     7254      +68     
==========================================
+ Hits         7145     7185      +40     
- Misses         41       69      +28     
Impacted Files Coverage Δ
src/date.rs 100.00% <100.00%> (ø)
src/duration.rs 100.00% <100.00%> (ø)
src/lib.rs 100.00% <100.00%> (ø)
src/offset_date_time.rs 99.48% <100.00%> (+<0.01%) ⬆️
src/primitive_date_time.rs 100.00% <100.00%> (ø)
src/time.rs 100.00% <100.00%> (ø)
src/utc_offset.rs 100.00% <100.00%> (ø)
src/sys/local_offset_at/unix.rs 25.64% <0.00%> (-71.80%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jhpratt jhpratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's do this. Only change is deduplication, as the PR as-is needlessly doubles up the code.

You'll also need to rebase, though this shouldn't cause any conflicts. This is because I updated CI, so it won't pass on the PR unless it's rebased.

src/date.rs Outdated Show resolved Hide resolved
@jhpratt jhpratt removed the C-keep-open Category: should not be closed due to inactivity label Oct 1, 2022
@xy2i xy2i force-pushed the debug branch 3 times, most recently from 37a5fe7 to cec2e41 Compare October 1, 2022 07:54
@xy2i xy2i requested a review from jhpratt October 1, 2022 07:55
src/time.rs Show resolved Hide resolved
src/offset_date_time.rs Outdated Show resolved Hide resolved
@xy2i xy2i requested review from jhpratt and removed request for jhpratt October 1, 2022 13:16
@jhpratt
Copy link
Member

jhpratt commented Oct 2, 2022

It appears as though nothing has been changed since my previous comment. Did you forget to push something?

Also don't worry about the codecov/project. That's on my end. It dropped for a reason I'm not certain about.

Same as Display for now
@xy2i
Copy link
Contributor Author

xy2i commented Oct 2, 2022

My bad :) Should be good now.

@jhpratt
Copy link
Member

jhpratt commented Oct 2, 2022

Looks good now! I'll take a final look over once I'm on my laptop. I also want to look into the internal compiler error when generating coverage, as that should never happen (not your fault).

@jhpratt
Copy link
Member

jhpratt commented Oct 3, 2022

Unfortunately I am able to reproduce the internal compiler error on the currently nightly. This is unrelated to this PR, as I can reproduce it on the current main. Consequently I see no reason not to merge this.

Thank you!

@jhpratt jhpratt merged commit 145f90d into time-rs:main Oct 3, 2022
@jhpratt jhpratt added A-core Area: anything not otherwise covered C-enhancement Category: an enhancement with existing code labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: anything not otherwise covered C-enhancement Category: an enhancement with existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nicer (alternative?) Debug implementations
2 participants