Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect RFC3339 offset parsing #478

Merged
merged 1 commit into from Jun 18, 2022

Conversation

zhu-he
Copy link
Contributor

@zhu-he zhu-he commented Jun 15, 2022

Fix a bug when parsing RFC3339 offset in range from -00:01 to -00:59.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #478 (11fe2fb) into main (9a3f985) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files          70       70           
  Lines        7201     7206    +5     
=======================================
+ Hits         7164     7169    +5     
  Misses         37       37           
Impacted Files Coverage Δ
src/parsing/parsable.rs 98.75% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a3f985...11fe2fb. Read the comment docs.

@jhpratt jhpratt self-requested a review June 15, 2022 21:10
@jhpratt jhpratt added C-bug Category: bug in current code C-keep-open Category: should not be closed due to inactivity A-parsing Area: parsing A-well-known-format-description Area: well known format descriptions labels Jun 15, 2022
@jhpratt
Copy link
Member

jhpratt commented Jun 18, 2022

Good catch. Thank you!

@jhpratt jhpratt merged commit eafddc5 into time-rs:main Jun 18, 2022
@jhpratt jhpratt removed the C-keep-open Category: should not be closed due to inactivity label Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parsing Area: parsing A-well-known-format-description Area: well known format descriptions C-bug Category: bug in current code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants