Parse nulls as None on nested serde structs #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stusmall
force-pushed
the
fix-parsing-of-nulls
branch
2 times, most recently
from
2bd853c
to
5438d1b
Compare
Codecov Report
@@ Coverage Diff @@
## main #473 +/- ##
=======================================
Coverage 99.48% 99.48%
=======================================
Files 70 70
Lines 7206 7209 +3
=======================================
+ Hits 7169 7172 +3
Misses 37 37
Continue to review full report at Codecov.
|
stusmall
force-pushed
the
fix-parsing-of-nulls
branch
2 times, most recently
from
83f377d
to
bdd1da6
Compare
stusmall
changed the title
jhpratt
added
A-parsing
|
This pull request has not had any activity recently. It will be closed without further activity. |
jhpratt
added
C-keep-open
|
Would you mind rebasing? I think it's a matter of moving the new method into the newly-created macro. |
When parsing a structure nested inside an untagged enum serde treats keys with a null value as Unit instead of calling visit_none. This causes an error of "invalid type: null, expected an RFC3339-formatted `Option<OffsetDateTime>`". This change just adds an implementation for visit_unit so the value will be parsed as None as expected.
jhpratt
force-pushed
the
fix-parsing-of-nulls
branch
from
bdd1da6
to
7bb7748
Compare
jhpratt
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a structure nested inside an untagged enum serde treats
keys with a null value as Unit instead of calling visit_none. This
causes an error of "invalid type: null, expected an
RFC3339-formatted
Option<OffsetDateTime>". This change just adds animplementation for visit_unit so the value will be parsed as None as
expected.