Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In BlobGCJob::DoRunGC(), the file_size is always = 0. #236

Open
apple-ouyang opened this issue Apr 21, 2022 · 3 comments
Open

In BlobGCJob::DoRunGC(), the file_size is always = 0. #236

apple-ouyang opened this issue Apr 21, 2022 · 3 comments
Labels
type/bug Type: Issue - Confirmed a bug

Comments

@apple-ouyang
Copy link
Contributor

In BlobGCJob::DoRunGC(), the file_size is always = 0.
I guess this variable is used to accumulate the file size of blob file.
Once the file_size >= blob_gc_->titan_cf_options().blob_file_target_size, Titan will create a new blob file right?
But there is no file_size += blob file size code.
So should we add some code or just delte the file_size?
@Connor1996 Connor1996 added the type/bug Type: Issue - Confirmed a bug label Apr 21, 2022
@Connor1996
Copy link
Member

Nice catch. Yes, the code is missing. Would you like to fix it?

@apple-ouyang
Copy link
Contributor Author

yeah, I will try to make a PR

@apple-ouyang apple-ouyang mentioned this issue Apr 21, 2022
Open
@apple-ouyang
Copy link
Contributor Author

I have make a PR here #237

@Connor1996 Connor1996 mentioned this issue Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Type: Issue - Confirmed a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Connor1996 @apple-ouyang