Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RocksDB makes sure the order of notifying OnFlushCompleted and OnCompactionCompleted #179

Open
Connor1996 opened this issue Jul 6, 2020 · 2 comments
Open

RocksDB makes sure the order of notifying OnFlushCompleted and OnCompactionCompleted #179

Connor1996 opened this issue Jul 6, 2020 · 2 comments
Labels
sig/engine Component: Engine (SIG)

Comments

@Connor1996
Copy link
Member

Connor1996 commented Jul 6, 2020 •
edited

In this PR facebook/rocksdb#6342, it fixes the issue that OnFlushCompleted and OnCompactionCompleted are called out of order which is the root cause of what #172 fixes.

After it is merged into our branch, we can remove the extra logic in Titan
@Connor1996 Connor1996 added the sig/engine Component: Engine (SIG) label Jul 6, 2020
@yiwu-arbug
Copy link
Collaborator

Sadly that PR was abandoned..

@Connor1996
Copy link
Member Author

@yiwu-arbug oh, didn't notice that it is closed. I was though it is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/engine Component: Engine (SIG)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yiwu-arbug @Connor1996