Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raft snapshot file is not deleted if the leader fails to send it out #16976

Closed
hbisheng opened this issue May 9, 2024 · 1 comment · Fixed by #16977
Closed

Raft snapshot file is not deleted if the leader fails to send it out #16976

hbisheng opened this issue May 9, 2024 · 1 comment · Fixed by #16977
Labels
severity/minor type/bug Type: Issue - Confirmed a bug

Comments

@hbisheng
Copy link
Contributor

hbisheng commented May 9, 2024 •
edited

Bug Report

There is a minor bug where the raft snapshot file is not deleted if the leader fails to send it out. I'll link a PR with an integration test that will demonstrate this.
@hbisheng hbisheng added the type/bug Type: Issue - Confirmed a bug label May 9, 2024
@hbisheng hbisheng mentioned this issue May 9, 2024
Merged
9 tasks
@hbisheng
Copy link
Contributor Author

hbisheng commented May 9, 2024

This is a minor bug. I'm trying to add a severity/minor label but don't know how.

ti-chi-bot bot added a commit that referenced this issue May 16, 2024
@hbisheng @LykxSassinator @ti-chi-bot
raftstore: fix a bug where snapshot file is not deleted in time (#16977)
3c2cbcf 
close #16976

The issue is that if a leader fails to send a snapshot, it doesn't delete the 
snapshot file which may accumulate and waste disk space. The idle snapshot 
files will eventually be GCed, but that might take hours. The commit ensures 
that the snapshot file is also deleted on the error path. A new integration 
test was added which would fail without the fix.

Signed-off-by: Bisheng Huang <hbisheng@gmail.com>

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/minor type/bug Type: Issue - Confirmed a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

raftstore: fix a bug where snapshot file is not deleted in time hbisheng/tikv
2 participants
@hbisheng @Connor1996