Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider remove the raft gc thread #16795

Open
glorv opened this issue Apr 10, 2024 · 4 comments
Open

consider remove the raft gc thread #16795

glorv opened this issue Apr 10, 2024 · 4 comments
Labels
type/question Type: Issue - Question

Comments

@glorv
Copy link
Contributor

glorv commented Apr 10, 2024

After introducing raft-engine, the cost of raft log gc task is almost the same as a normal write. Thus, it's unnecessary to still use a separate thread to handle log gc. While the current aync gc approach is unlikely to be a bottleneck, it makes the codebase a litter simpler.

@glorv glorv added the type/question Type: Issue - Question label Apr 10, 2024
@glorv
Copy link
Contributor Author

glorv commented Apr 10, 2024

/cc @Connor1996 @overvenus @LykxSassinator @tonyxuqqi what do you think?

@LykxSassinator
Copy link
Contributor

Emmm....Unless we announce that rocksdb-raft will not be maintained in the future.

Currently, if the user still wanna use rocksdb-raft option, this change might have side effects to the performance when gc raft logs.

@Connor1996
Copy link
Member

We can first remove the support of rocksdb-raft

@LykxSassinator
Copy link
Contributor

We can first remove the support of rocksdb-raft

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/question Type: Issue - Question
Projects
None yet
Development

No branches or pull requests

3 participants