Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crates.io badge #436

Merged
merged 1 commit into from Mar 2, 2022
Merged

Fix crates.io badge #436

merged 1 commit into from Mar 2, 2022

Conversation

jaseemabid
Copy link
Contributor

Not sure what happened to http://meritbadge.herokuapp.com, but it's not running anymore and points to default heroku error page.

Sheilds.io has a crates.io integration, so this should just work out of the box.

![crates.io](https://img.shields.io/crates/v/$CRATE.svg)

Example crates.io

Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks!

@lucab
Copy link
Member

lucab commented Feb 28, 2022

@jaseemabid could you please sign-off your commit in order to pass DCO check in CI?

Not sure what happened to http://meritbadge.herokuapp.com, but it's not running anymore and points to default heroku error page.

Sheilds.io has a crates.io integration, so this should just work out of the box.

```
![crates.io](https://img.shields.io/crates/v/$CRATE.svg)
```

Example [![crates.io](https://img.shields.io/crates/v/prometheus.svg)](https://crates.io/crates/prometheus)

Signed-off-by: Jaseem Abid <me@jabid.in>
@jaseemabid
Copy link
Contributor Author

Updated.

@lucab
Copy link
Member

lucab commented Mar 2, 2022

Thanks, LGTM!

@lucab lucab merged commit 117b0df into tikv:master Mar 2, 2022
@jaseemabid jaseemabid deleted the patch-1 branch March 2, 2022 16:59
@lucab lucab mentioned this pull request Apr 21, 2022
JanBerktold pushed a commit to JanBerktold/rust-prometheus that referenced this pull request Nov 12, 2022
Not sure what happened to http://meritbadge.herokuapp.com, but it's not running anymore and points to default heroku error page.

Sheilds.io has a crates.io integration, so this should just work out of the box.

```
![crates.io](https://img.shields.io/crates/v/$CRATE.svg)
```

Example [![crates.io](https://img.shields.io/crates/v/prometheus.svg)](https://crates.io/crates/prometheus)

Signed-off-by: Jaseem Abid <me@jabid.in>
Signed-off-by: Jan Berktold <jberktold@roblox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants