Fix re-export of TEXT_FORMAT to not require protobuf #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, good catch! |
A minor change, but previously the root-level re-export of TEXT_FORMAT would require cfg(feature = "protobuf"), despite the text export format not requiring protobufs. Since this is the only location where TEXT_FORMAT is made public, it should be exported regardless of protobuf feature availability. Signed-off-by: Jeremy Rodi <me@telios.dev>
lucab
approved these changes
Oct 11, 2021
JanBerktold
pushed a commit
to JanBerktold/rust-prometheus
that referenced
this pull request
Nov 12, 2022
A minor change, but previously the root-level re-export of TEXT_FORMAT would require cfg(feature = "protobuf"), despite the text export format not requiring protobufs. Since this is the only location where TEXT_FORMAT is made public, it should be exported regardless of protobuf feature availability. Signed-off-by: Jeremy Rodi <me@telios.dev> Signed-off-by: Jan Berktold <jberktold@roblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor change, but previously the root-level re-export of
TEXT_FORMATwould requirecfg(feature = "protobuf"), despite the text export format not requiring protobufs. Since this is the only location whereTEXT_FORMATis made public, it should be exported regardless of protobuf feature availability.