feat(macros): add macros for collectors with custom registry #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moustafab
force-pushed
the
moustafab/registry-macro
branch
from
079d604
to
dd3f81c
Compare
moustafab
changed the title
moustafab
force-pushed
the
moustafab/registry-macro
branch
from
dd3f81c
to
c287add
Compare
|
@lucab @breeswish just thought I'd see if I could bump this to the top of your queues for review. Thanks! |
moustafab
force-pushed
the
moustafab/registry-macro
branch
from
c287add
to
ae6a166
Compare
|
@lucab @breeswish Friendly reminder! |
lucab
reviewed
Aug 10, 2021
|
@moustafab thanks, it looks great! I've left a minor comment for the doc-example. Can you please rebase this on master? |
Signed-off-by: Moustafa Baiou <moustafa@ditto.live>
moustafab
force-pushed
the
moustafab/registry-macro
branch
from
ae6a166
to
d472e3d
Compare
|
@lucab rebased and hopefully ready to merge! |
lucab
approved these changes
Aug 11, 2021
JanBerktold
pushed a commit
to JanBerktold/rust-prometheus
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Moustafa Baiou <moustafa@ditto.live> Signed-off-by: Jan Berktold <jberktold@roblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds macros for static instantiation of collectors using a custom registry.
Addresses #386