New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow trailing commas on macros #390
Conversation
I guess all I needs to do for the DCO issue is to append the |
@HyeonuPark thanks for the PR! Indeed, your commit should be signed off to pass CI checks. Travis failure is due to #391 and should go away if you rebase to latest master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Could you also supply some unit tests to verify that this syntax pass the compiling? In this way we can avoid some future mistakes :) For example, you can just write a test importing the macro and then use these macros with trailing commas.
@HyeonuPark ping, do you plan to come back to this soon-ish? |
Sorry for the super late reply! If it's still OK, I'll supplement it within this week. |
Shameless copy-pastes from doc comments with additional comma per invocation. :) I can't say anymore it's a tiny change w.r.t. the LoC. |
Signed-off-by: Hyeonu Park <nemo1275@gmail.com>
Applied cargo fmt on it. |
Thanks a lot, LGTM! |
Signed-off-by: Hyeonu Park <nemo1275@gmail.com> Signed-off-by: Jan Berktold <jberktold@roblox.com>
This PR allows to append optional comma after the last argument of those opts!/register! like macros.