From 2e0458085cccbea6c0cfb41ed809b5d0d6fbb375 Mon Sep 17 00:00:00 2001
From: YangKeao <yangkeao@chunibyo.icu>
Date: Fri, 19 Aug 2022 18:06:28 +0800
Subject: [PATCH] ignore prost mod and fix clippy warning

Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
---
 src/lib.rs    |  1 +
 src/report.rs | 15 ++++++++-------
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index ed87e566..01025a42 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -65,6 +65,7 @@ pub use self::report::{Report, ReportBuilder, UnresolvedReport};
 #[cfg(feature = "flamegraph")]
 pub use inferno::flamegraph;
 
+#[allow(clippy::all)]
 #[cfg(all(feature = "prost-codec", not(feature = "protobuf-codec")))]
 pub mod protos {
     pub use prost::Message;
diff --git a/src/report.rs b/src/report.rs
index a19b940e..37b885a8 100644
--- a/src/report.rs
+++ b/src/report.rs
@@ -29,9 +29,11 @@ pub struct UnresolvedReport {
     pub timing: ReportTiming,
 }
 
+type FramesPostProcessor = Box<dyn Fn(&mut Frames)>;
+
 /// A builder of `Report` and `UnresolvedReport`. It builds report from a running `Profiler`.
 pub struct ReportBuilder<'a> {
-    frames_post_processor: Option<Box<dyn Fn(&mut Frames)>>,
+    frames_post_processor: Option<FramesPostProcessor>,
     profiler: &'a RwLock<Result<Profiler>>,
     timing: ReportTiming,
 }
@@ -159,13 +161,13 @@ impl Debug for Report {
 mod flamegraph {
     use super::*;
     use inferno::flamegraph;
-    use std::io::Write;
+    use std::fmt::Write;
 
     impl Report {
         /// `flamegraph` will write an svg flamegraph into `writer` **only available with `flamegraph` feature**
         pub fn flamegraph<W>(&self, writer: W) -> Result<()>
         where
-            W: Write,
+            W: std::io::Write,
         {
             self.flamegraph_with_options(writer, &mut flamegraph::Options::default())
         }
@@ -177,7 +179,7 @@ mod flamegraph {
             options: &mut flamegraph::Options,
         ) -> Result<()>
         where
-            W: Write,
+            W: std::io::Write,
         {
             let lines: Vec<String> = self
                 .data
@@ -188,13 +190,12 @@ mod flamegraph {
 
                     for frame in key.frames.iter().rev() {
                         for symbol in frame.iter().rev() {
-                            line.push_str(&format!("{}", symbol));
-                            line.push(';');
+                            write!(&mut line, "{};", symbol).unwrap();
                         }
                     }
 
                     line.pop().unwrap_or_default();
-                    line.push_str(&format!(" {}", value));
+                    write!(&mut line, " {}", value).unwrap();
 
                     line
                 })