add phantom data for criterion output #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YangKeao <keao.yang@yahoo.com>
Signed-off-by: YangKeao <keao.yang@yahoo.com>
Signed-off-by: YangKeao <keao.yang@yahoo.com>
Signed-off-by: YangKeao <keao.yang@yahoo.com>
Hexilee
approved these changes
Jul 13, 2021
| @@ -51,6 +60,10 @@ impl<'a, 'b> Profiler for PProfProfiler<'a, 'b> { | |||
| Output::Flamegraph(_) => "flamegraph.svg", | |||
| #[cfg(feature = "protobuf")] | |||
| Output::Protobuf => "profile.pb", | |||
| // This is `""` but not `unreachable!()`, because `unreachable!()` | |||
| // will result in another compile error, so that the user may not | |||
There was a problem hiding this comment.
Can really unreachable!() cause compile error? I do not realize it.
There was a problem hiding this comment.
If the only branch is "unreachable!()", the type of "filename" will be resolved as (), and it's illegal to pass filename to benchmark_dir.join.
Though, adding a redundant type annotation : &str to the filename will fix this issue, it will also bring a big warning (because the following statement is unreachable statement in that case), so I prefer to return an empty string, and let the compile_error prints the only error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #66
Signed-off-by: YangKeao keao.yang@yahoo.com