Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart syscalls interrupted by SIGPROF when possible #167

Merged
merged 1 commit into from Oct 26, 2022

Conversation

funbringer
Copy link
Contributor

@funbringer funbringer commented Oct 24, 2022

This is more convenient, because one would no longer need to check for EINTR in certain places. Of course, there's a bunch of syscalls like epoll which may still return EINTR, but at least pprof will be less likely to break sloppy code.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

Good job! Please add the sign-off ❤️.

Signed-off-by: Dmitry Ivanov <ivadmi5@gmail.com>
@funbringer
Copy link
Contributor Author

Done! Thank you for the quick reply.

@YangKeao YangKeao merged commit 059d3c8 into tikv:master Oct 26, 2022
@funbringer funbringer deleted the funbringer/sigaction-restart branch October 26, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants