ignore prost mod and fix clippy warning #160
Conversation
YangKeao
force-pushed
the
fix-complicate-type-clippy
branch
from
9b251e2
to
8fdcca3
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
YangKeao
force-pushed
the
fix-complicate-type-clippy
branch
from
8fdcca3
to
2e04580
Compare
| @@ -65,6 +65,7 @@ pub use self::report::{Report, ReportBuilder, UnresolvedReport}; | |||
| #[cfg(feature = "flamegraph")] | |||
| pub use inferno::flamegraph; | |||
|
|
|||
| #[allow(clippy::all)] | |||
There was a problem hiding this comment.
Why? What problem it's trying to solve?
There was a problem hiding this comment.
See https://github.com/tikv/pprof-rs/runs/7899854996?check_suite_focus=true, it ignores the clippy error produced in the codes generated by prost.
There was a problem hiding this comment.
Is it better to be more conservative about suppressing warnings like in tokio-rs/prost#661 (comment)?
There was a problem hiding this comment.
Is it better to be more conservative about suppressing warnings like in tokio-rs/prost#661 (comment)?
@sticnarf I don't think so. If more clippy warnings appears in the prost mod, what we can do is still ignoring them. It seems that being more conservative doesn't make it better.
There was a problem hiding this comment.
The advantage I can think of is when it's a warning about correctness or performance, it's possible to find and report to the prost upstream. Well, of course, we can rely on others using prost to do the same.
I think both are ok.
|
/merge |
Signed-off-by: YangKeao yangkeao@chunibyo.icu