New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase stack max depth at 128 #159
Conversation
@YangKeao if this looks good to you and it's merged, could you please create a new release after? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd fix some clippy before merge this PR 😸 . |
@YangKeao thanks for taking such a quick look at this 😀
I'm a bit confused about this. Do you mean making I see most of the warnings come from the I can only see a few warnings coming from And sometimes those warnings seems very stricts (see example below) and I'm not sure if they should be treated as an error
|
See #160 . I fixed some clippy warnings themselves, and allow all inside the prost mod. |
I think you can just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@viglia Please fix the DCO (by |
cdd8905
to
726cbf3
Compare
Signed-off-by: Francesco Vigliaturo <francesco.vigliaturo@sentry.io>
726cbf3
to
f416238
Compare
At the moment
MAX_DEPTH
is set to 32.This is a bit low as a value and in some cases important frames are cut out of the final result.