Adds timing info to each sample #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viglia
force-pushed
the
viglia/enhance/add-sample-timing-info
branch
from
0d0a125
to
d8bd3bb
Compare
YangKeao
reviewed
Jun 9, 2022
viglia
force-pushed
the
viglia/enhance/add-sample-timing-info
branch
from
72659dd
to
3ce1876
Compare
Signed-off-by: Francesco Vigliaturo <viglia90@gmail.com>
Signed-off-by: Francesco Vigliaturo <viglia90@gmail.com>
Signed-off-by: Francesco Vigliaturo <viglia90@gmail.com>
viglia
force-pushed
the
viglia/enhance/add-sample-timing-info
branch
from
3ce1876
to
32352a9
Compare
|
@YangKeao thanks for looking over this PR. I've updated the |
|
@YangKeao thanks for merging the other PR. I think this is good to go as well? |
Jardynq
pushed a commit
to Jardynq/pprof-rs
that referenced
this pull request
Jul 24, 2022
* Adds timing info to each sample Signed-off-by: Francesco Vigliaturo <viglia90@gmail.com> * Updates the CHANGELOG.md Signed-off-by: Francesco Vigliaturo <viglia90@gmail.com> * Add PR info to updated CHANGELOG.md Signed-off-by: Francesco Vigliaturo <viglia90@gmail.com> Co-authored-by: YangKeao <yangkeao@chunibyo.icu> Signed-off-by: Christian Jordan <svorre2304@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we only have timing info at
Reportlevel. We don't have more fine grained timing info for the samples collected.This PR aims at adding timing info (
sample_timestamp) to the samples collected.