Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export UnresolvedReport #132

Merged
merged 2 commits into from Jun 16, 2022

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Jun 1, 2022

This let the user the option to get an unsymbolicated report.

Useful when the user is not interested in symbolication on the client.

Thanks to this is possible to collect the absolute addresses (frame instruction pointer) instead of the relative address crafted by resolve_symbol.

With this absolute address is then possible to run symbolication as a separate process with the support of the debug symbol files if needed.

This let the user the option to get an unsymbolicated report.

Useful when the user is not interested in symbolication on the client.

Signed-off-by: Francesco Vigliaturo <viglia90@gmail.com>
@viglia viglia force-pushed the viglia/enhance/export-unresolved-report branch from 4ca170a to 91c76ca Compare June 1, 2022 19:07
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please modify the CHANGELOG.md. Rest LGTM.

I remembered someone added the UnresolvedReport to allow developers to get the unresolved report, but it's not exported 😲 ! Really wired.

Signed-off-by: Francesco Vigliaturo <viglia90@gmail.com>
@viglia viglia force-pushed the viglia/enhance/export-unresolved-report branch from b1bb220 to 298be23 Compare June 9, 2022 08:47
@viglia
Copy link
Contributor Author

viglia commented Jun 9, 2022

@YangKeao thanks for looking over this PR.

I've updated the CHANGELOG.md as requested.

@viglia viglia requested a review from YangKeao June 9, 2022 08:59
@viglia
Copy link
Contributor Author

viglia commented Jun 14, 2022

Hi @YangKeao , any update ?

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao YangKeao merged commit 108d0d6 into tikv:master Jun 16, 2022
@viglia viglia deleted the viglia/enhance/export-unresolved-report branch June 16, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants