Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize mutually exclusive features #130

Merged
merged 3 commits into from May 24, 2022
Merged

Conversation

mornyx
Copy link
Contributor

@mornyx mornyx commented May 20, 2022

In general, using mutually exclusive features will cause some trouble in downstream. Some reasons can be found here: https://doc.rust-lang.org/cargo/reference/features.html#mutually-exclusive-features

Signed-off-by: mornyx mornyx.z@gmail.com

Signed-off-by: mornyx <mornyx.z@gmail.com>
@YangKeao
Copy link
Member

Please also modify the CHANGELOG.md . It's a change and we'll release a 0.10.0 version for it 😢

@mornyx
Copy link
Contributor Author

mornyx commented May 20, 2022

Please also modify the CHANGELOG.md . It's a change and we'll release a 0.10.0 version for it 😢

Maybe we can add a section named master to record all the latest changes and migrate them to 0.10.0 section on the next release time?

@YangKeao
Copy link
Member

@mornyx

The [Unreleased] section?

@mornyx
Copy link
Contributor Author

mornyx commented May 20, 2022

The [Unreleased] section?

Oh, that's it! How about I add it to [Unreleased] first? Maybe this change wasn't enough to release a version on its own.

Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
@mornyx
Copy link
Contributor Author

mornyx commented May 20, 2022

Should this be Changed or Removed, what is your opinion? 🤔

@YangKeao
Copy link
Member

Oh, that's it! How about I add it to [Unreleased] first? Maybe this change wasn't enough to release a version on its own.

Yes. It's expected. I'll rename the Unreleased to 0.10.0 and create a new Unreleased when I release that version.

Should this be Changed or Removed, what is your opinion?

IMO, Changed is better.

@mornyx
Copy link
Contributor Author

mornyx commented May 24, 2022

/assign @YangKeao Ping~ Please see if there is any room for improvement.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao YangKeao merged commit 3fed55a into tikv:master May 24, 2022
@mornyx mornyx deleted the optimize-features branch May 25, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants