Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support rust-protobuf #106

Merged
merged 7 commits into from Mar 4, 2022
Merged

*: support rust-protobuf #106

merged 7 commits into from Mar 4, 2022

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Mar 3, 2022

Close #23.

@BusyJay
*: support rust-protobuf
5a55753 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay requested a review from YangKeao March 3, 2022 09:57
@BusyJay
remove bytes feature
2a3b6e9 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@YangKeao
Copy link
Member

YangKeao commented Mar 3, 2022 •
edited

The GitHub action should be updated to not enable all features for Clippy 🤔

@BusyJay
allow all-features
94e38a8 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
don't use keyword
193b333 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
Copy link
Member Author

BusyJay commented Mar 3, 2022

It's tested in TiKV.

@BusyJay
update github actions
e0da71c 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
make clippy happy
5452f16 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
YangKeao
YangKeao approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BusyJay Please update the CHANGELOG.md, then it can be merged 😃

@BusyJay
update CHANGELOG
11af700 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
Copy link
Member Author

BusyJay commented Mar 4, 2022

I use a new format of changelog that reference PR instead of authors. This may be more informative.

@YangKeao
Copy link
Member

YangKeao commented Mar 4, 2022

I use a new format of changelog that reference PR instead of authors. This may be more informative.

Good.

@YangKeao YangKeao merged commit 400456e into master Mar 4, 2022
@BusyJay BusyJay deleted the support-rust-protobuf branch March 4, 2022 06:45
@BusyJay
Copy link
Member Author

BusyJay commented Mar 4, 2022

Note this is a breaking change, and should not be released as a patch version. Though TiKV can use url directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BusyJay @YangKeao