Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: allow client send consecutive pings in every 5 seconds #8120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

grpc: allow client send consecutive pings in every 5 seconds #8120

wants to merge 1 commit into from
+9 −1

Conversation

yongman
Copy link

@yongman yongman commented Apr 23, 2024

What problem does this PR solve?

Issue Number: Close #8119

What is changed and how does it work?

grpc: allow client send consecutive pings in every 5 seconds

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release note

None.

@yongman
grpc: allow client send consecutive pings in every 5 seconds
81e1f47 
Signed-off-by: yongman <yming0221@gmail.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx April 23, 2024 07:43
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

Hi @yongman. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2024
@HuSharp
Copy link
Member

HuSharp commented Apr 23, 2024

/ok-to-test

@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited

Codecov Report

Merging #8120 (81e1f47) into master (5cdf252) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8120      +/-   ##
==========================================
+ Coverage   77.29%   77.30%   +0.01%     
==========================================
  Files         470      470              
  Lines       61143    61147       +4     
==========================================
+ Hits        47260    47272      +12     
+ Misses      10320    10307      -13     
- Partials     3563     3568       +5
Flag Coverage Δ
unittests 77.30% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp
Copy link
Member

HuSharp commented Apr 24, 2024

/check-issue-triage-complete

@yongman
Copy link
Author

yongman commented Apr 25, 2024

@HuSharp PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 Awaiting requested review from lhy1024

@rleungx rleungx Awaiting requested review from rleungx

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ok-to-test release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tso client receive GOAWAY when idle with keepalive
2 participants
@yongman @HuSharp