tests: avoid some test branches not being reached #8087
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
size/L
| @@ -527,25 +534,12 @@ func checkHotWriteRegionScheduleByteRateOnly(re *require.Assertions, enablePlace | |||
| clearPendingInfluence(hb.(*hotScheduler)) | |||
| tc.SetHotRegionScheduleLimit(int(opt.GetHotRegionScheduleLimit())) | |||
|
|
|||
| for i := 0; i < 20; i++ { | |||
There was a problem hiding this comment.
This part is duplicated with L500-L522. But this branch, which tests the transfer leader, is not reached, so it is not updated before.
| pdServerCfg := tc.GetPDServerConfig() | ||
| pdServerCfg.FlowRoundByDigit = 8 |
There was a problem hiding this comment.
Add config to avoid test branches not being reached
| re.Equal("move-hot-write-leader", op.Desc()) | ||
| operatorutil.CheckTransferLearner(re, op, operator.OpHotRegion, 8, 10) | ||
| re.Equal("move-hot-write-peer", op.Desc()) | ||
| operatorutil.CheckTransferLearner(re, op, operator.OpHotRegion, 8, 0) |
There was a problem hiding this comment.
it may be scheduled to store 10 or store 11
Signed-off-by: lhy1024 <admin@liudos.us>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8087 +/- ##
==========================================
- Coverage 77.40% 77.38% -0.03%
==========================================
Files 471 471
Lines 61456 61355 -101
==========================================
- Hits 47569 47477 -92
+ Misses 10323 10315 -8
+ Partials 3564 3563 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
What problem does this PR solve?
Issue Number: Close #8073
What is changed and how does it work?
schedulePeerPr always be 1.0, which makes some test cannot reach transfer-leader branch
Check List
Tests
Release note