Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility statement regarding Placement Rules in SQL and PD location-labels #8003

Open
snowballbear opened this issue Mar 29, 2024 · 1 comment
Labels
found/gs type/enhancement The issue belongs to an enhancement.

Comments

@snowballbear
Copy link

Enhancement Task

Users following the official documentation to create placement policies using placement rule in SQL have found discrepancies between peer distribution and the location-labels setting.
The rules set by the location-labels configuration in PD won't take effect automatically unless the same rules are specified using SURVIVAL_PREFERENCES when creating placement policy. https://docs.pingcap.com/zh/tidb/stable/placement-rules-in-sql#%E6%8C%87%E5%AE%9A%E7%94%9F%E5%AD%98%E5%81%8F%E5%A5%BD

1、The documentation for "Placement Rules in SQL"(https://docs.pingcap.com/zh/tidb/stable/placement-rules-in-sql#placement-rules-in-sql)currently doesn‘t mention that “Placement Rules in SQL is incompatible with the location-labels configuration of PD and ignores this configuration” which is mentioned in another document (https://docs.pingcap.com/zh/tidb/stable/schedule-replicas-by-topology-labels#%E8%AE%BE%E7%BD%AE-pd-%E7%9A%84-location-labels-%E9%85%8D%E7%BD%AE), where it is simply stated that "SURVIVAL_PREFERENCES is equivalent to location-labels in PD." This may cause confusion for users.
It is recommended to provide a clear statement regarding this in the "Placement Rules in SQL" documentation.

2、Please evaluate whether it is feasible to have "Placement Rules in SQL" inherit the placement rules from PD location-labels by default.

@snowballbear snowballbear added the type/enhancement The issue belongs to an enhancement. label Mar 29, 2024
@snowballbear
Copy link
Author

/found gs

@ti-chi-bot ti-chi-bot bot added the found/gs label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
found/gs type/enhancement The issue belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant