Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make #[trace] proc-macro-attribute IDE friendly #128

Closed
1 task done
taqtiqa-mark opened this issue Mar 23, 2022 · 1 comment
Closed
1 task done

Feature: Make #[trace] proc-macro-attribute IDE friendly #128

taqtiqa-mark opened this issue Mar 23, 2022 · 1 comment

Comments

@taqtiqa-mark
Copy link
Contributor

taqtiqa-mark commented Mar 23, 2022

This feature is implemented in PR #127.should not be attempted until the new pipeline refactoring lands, and related bugs are squashed:

At that point we should try to make the proc-macro parsing errors more recoverable. From the user perspective it should mean they get prompted about relevant functions. In our case a prompt to use record(..) on the variable name passed in via the recorder=spanr attribute option.

An illustration of what this looks like is here (Tokio specific).

Relevant resources:

@taqtiqa-mark
Copy link
Contributor Author

Voided by PR #127 rejection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant