Correct jemalloc commit hash #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brennan Vincent <brennan@materialize.com>
umanwizard
force-pushed
the
fix_broken_commit_hash
branch
from
74c38ab
to
62236db
Compare
|
Interesting, how come it passed the CI before |
|
I am not 100% sure of the details of when GitHub keeps around commits that are not the ancestor of some head -- but I suspect it is because my PR (containing 95966b7 ) to tikv/jemalloc was still open, and therefore the commit 95966b7 could be found. |
sticnarf
approved these changes
Aug 9, 2021
|
tikv-jemalloc-sys 0.4.2 is shipped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 95966b7 was intended to refer to tikv/jemalloc#2 . However, when that PR was actually merged, the commit hash was in fact 172143a . Thus tikv/jemallocator needs to be updated to refer to the correct hash.