Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System libraries versions (grpc) #591

Open
gabriel-doriath-dohler opened this issue Oct 13, 2022 · 6 comments
Open

System libraries versions (grpc) #591

gabriel-doriath-dohler opened this issue Oct 13, 2022 · 6 comments

Comments

@gabriel-doriath-dohler
Copy link

gabriel-doriath-dohler commented Oct 13, 2022

Is there a way to retrieve the correct (and tested) versions for system libraries such as grpc?
Currently, it can be extracted using cargo metadata and sed 's/^.*+//;s/-.*$//', as the grpcio-sys version includes the grpc version.
Will this be stable or will the naming convention change?

@BusyJay
Copy link
Member

BusyJay commented Oct 13, 2022

Why do you want that library?

@gabriel-doriath-dohler
Copy link
Author

gabriel-doriath-dohler commented Oct 13, 2022

I'm using pkg-config and GRPCIO_SYS_USE_PKG_CONFIG=1, so I need to know the correct grpc version.
Currently I'm using the grpc version from the grpcio-sys version.
For example, I'm using grpc 1.44.0 for grpcio-sys v0.10.3+1.44.0-patched.

@gabriel-doriath-dohler
Copy link
Author

If the naming convention for grpcio-sys versions change, my regexpr will not work. So, will the convention change or do you provide any other stable way to get the correct grpc version?

@BusyJay
Copy link
Member

BusyJay commented Oct 13, 2022

Currently TiKV's version include a patch that is not merged into upstream. tikv/grpc@38a9cd9. So use customized library may miss the functionality. I would not say the format of grpcio-sys version name is reliable. But I don't see it will change in the near future. The format is {grpcio-sys version}+{grpc version}[-patched[.1]. -patched part means whether we have included unreleased patch based on the grpc version. -patched.1 means more patches than -patched are included in the grpc.

@gabriel-doriath-dohler
Copy link
Author

Thanks a lot! Where can I get a list of all patches that are not merged upstream, so that I can apply them?

@BusyJay
Copy link
Member

BusyJay commented Oct 14, 2022

Currently there is only one functionality difference. You can get what's changed by git diff {grpcio-sys version}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants