Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: the logs in client-go are not fully red-acted #1047

Open
cfzjywxk opened this issue Oct 31, 2023 · 2 comments
Open

server: the logs in client-go are not fully red-acted #1047

cfzjywxk opened this issue Oct 31, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@cfzjywxk
Copy link
Contributor

There are still some logs printting in the client-go code which are not red acted.
For example

[2023/10/25 23:02:59.305 +00:00] [WARN] [region_request.go:1898] ["tikv reports `DataIsNotReady` retry later"] [store-id=770512] [peer-id=6265849273] [region-id=6265849271] [safe-ts=445192389840081807] [ctx="region ID: 6265849271, meta: id:6265849271 start_key:\"t\\200\\000\\000\\000\\000\\001L\\235_r\\001PRIMARY_...
@cfzjywxk cfzjywxk added the enhancement New feature or request label Oct 31, 2023
@disksing
Copy link
Collaborator

you mean we should print in hex format?

@cfzjywxk
Copy link
Contributor Author

The keys are printted in raw value and not replaced with a questionmark, some of them are printted by the errors returned from tikv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cfzjywxk @disksing