Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update path containing @ since sjson 1.2.0 #66

Open
dunglas opened this issue Jan 13, 2023 · 1 comment
Open

Unable to update path containing @ since sjson 1.2.0 #66

dunglas opened this issue Jan 13, 2023 · 1 comment

Comments

@dunglas
Copy link

dunglas commented Jan 13, 2023

Hi,

First thanks for this great library.

Since version 1.2, if the path contains a @, it fails to update the document. This is similar to #61 but it's not resolved in version 1.2.5.

To reproduce, you can clone Vulcain and run this test: https://github.com/dunglas/vulcain/blob/f2d77e93a75ea803607bbc816c7eb1d534a2e7bc/server_test.go#L191

With version 1.1.7, it's green, but starting with version 1.2.0 it's red.

I hope this helps.

@dunglas
Copy link
Author

dunglas commented Feb 3, 2023

As a workaround, escaping special sjson chars fixes the issue: dunglas/vulcain#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant