Edk2Path: Add an env variable to allow nested packages #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an environment variable called `STUART_IGNORE_EDK_NESTED_PACKAGES` that a platform can set to `"true"` to allow nested packages. Nested packages are a violation of EDK II package rules and should be fixed. This is provided for backward compatibility and temporary use until the variable is no longer needed. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Codecov ReportBase: 78.40% // Head: 78.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 78.40% 78.42% +0.02%
==========================================
Files 91 91
Lines 10114 10125 +11
==========================================
+ Hits 7930 7941 +11
Misses 2184 2184
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
spbrogan
reviewed
Nov 9, 2022
spbrogan
reviewed
Nov 9, 2022
spbrogan
reviewed
Nov 9, 2022
spbrogan
reviewed
Nov 9, 2022
spbrogan
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an environment variable called
PYTOOL_TEMPORARILY_IGNORE_NESTED_EDK_PACKAGESthat a platform can set to
"true"to allow nested packages.Nested packages are a violation of EDK II package rules and should
be fixed. This is provided for backward compatibility and temporary
use until the variable is no longer needed.
Signed-off-by: Michael Kubacki michael.kubacki@microsoft.com