Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏ Fix link in docs to datetime.strptime() #464

Merged
merged 2 commits into from Nov 5, 2022
Merged

✏ Fix link in docs to datetime.strptime() #464

merged 2 commits into from Nov 5, 2022

Conversation

Kobu
Copy link
Contributor

@Kobu Kobu commented Oct 7, 2022

Issue:
Documentation claims formats receives a list of strings with the date formats that would be passed to datetime.strptime() however the actual link is pointing to date.strftime() as can be seen here

Fix
Replaced the incorrect link by one thats pointing to datetime.strptime()

@tiangolo tiangolo changed the title Docs: fix link pointing to a wrong method ✏ Fix link in docs to datetime.strptime() Nov 5, 2022
@tiangolo
Copy link
Owner

tiangolo commented Nov 5, 2022

Good catch, thanks @Kobu! 🚀

@tiangolo tiangolo enabled auto-merge (squash) November 5, 2022 14:29
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 96.24% // Head: 100.00% // Increases project coverage by +3.75% 🎉

Coverage data is based on head (d147826) compared to base (1e43c6b).
Patch has no changes to coverable lines.

❗ Current head d147826 differs from pull request most recent head 9df9562. Consider uploading reports for the commit 9df9562 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #464      +/-   ##
===========================================
+ Coverage   96.24%   100.00%   +3.75%     
===========================================
  Files         280       280              
  Lines        5942      5942              
===========================================
+ Hits         5719      5942     +223     
+ Misses        223         0     -223     
Impacted Files Coverage Δ
typer/models.py 100.00% <0.00%> (+2.41%) ⬆️
typer/core.py 100.00% <0.00%> (+7.87%) ⬆️
typer/_completion_shared.py 100.00% <0.00%> (+25.24%) ⬆️
typer/completion.py 100.00% <0.00%> (+31.42%) ⬆️
typer/_completion_click8.py 100.00% <0.00%> (+60.55%) ⬆️
typer/_completion_click7.py 100.00% <0.00%> (+78.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

📝 Docs preview for commit 9df9562 at: https://6366735b193dc17614e9c871--typertiangolo.netlify.app

@tiangolo tiangolo merged commit 523a650 into tiangolo:master Nov 5, 2022
alexreg pushed a commit to alexreg/typer-cloup that referenced this pull request Nov 6, 2022
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
alexreg pushed a commit to alexreg/typer-cloup that referenced this pull request Nov 11, 2022
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants