馃摑 Update Help FastAPI: Help Maintain FastAPI #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay! Much needed guideline! Hope the community follows and benefits for a collective and collaborative benefit!鉂わ笍 |
|
馃殌 Deployed on https://6371457ba5d3277ed69bd6b7--fastapi.netlify.app |
|
馃摑 Docs preview for commit 81c867c at: https://637145a33de31a02a6d37dfe--fastapi.netlify.app |
|
Thanks @iudeen! And thanks for all the help here! 馃檱 |
iudeen
suggested changes
Nov 13, 2022
|
|
||
| ### Ask to close | ||
|
|
||
| If they reply, there's a high chance you will have solved their problem, congrats, **you're a hero**! 馃Ω |
There was a problem hiding this comment.
Suggested change
| If they reply, there's a high chance you will have solved their problem, congrats, **you're a hero**! 馃Ω | |
| If they reply, there's a high chance you would have solved their problem, congrats, **you're a hero**! 馃Ω |
|
|
||
| You can help me review pull requests from others. | ||
|
|
||
| Again, please try as best to be kind. 馃 |
There was a problem hiding this comment.
Suggested change
| Again, please try as best to be kind. 馃 | |
| Again, please try your best to be kind. 馃 |
Felt it sounds better 馃槃
|
|
||
| ### Understand the problem | ||
|
|
||
| * First, make sure you **understand the problem** that the pull request is trying to solve. It might have a longer discussion in an issue. |
There was a problem hiding this comment.
Suggested change
| * First, make sure you **understand the problem** that the pull request is trying to solve. It might have a longer discussion in an issue. | |
| * First, make sure you **understand the problem** that the pull request is trying to solve. It might have a detailed discussion in an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Update Help FastAPI: Help Maintain FastAPI