Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add French translation for docs/fr/docs/advanced/additional-status-code.md #5477

Merged
merged 14 commits into from Nov 13, 2022
Merged

🌐 Add French translation for docs/fr/docs/advanced/additional-status-code.md #5477

merged 14 commits into from Nov 13, 2022

Conversation

axel584
Copy link
Contributor

@axel584 axel584 commented Oct 9, 2022

Here is the PR to translate the advanced/additional-status-code.md
See the french translation tracking issue #1972.

Thanks for the reviews

@codecov
Copy link

codecov bot commented Oct 9, 2022 •
edited

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e05d84f) compared to base (cf73051).
Patch has no changes to coverable lines.

❗ Current head e05d84f differs from pull request most recent head 705a52a. Consider uploading reports for the commit 705a52a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #5477   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       540           
  Lines        13969     13946   -23     
=========================================
- Hits         13969     13946   -23
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <0.00%> (ø)
tests/test_datastructures.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

📝 Docs preview for commit a1a7f72 at: https://63428b33fbdff17456e4b188--fastapi.netlify.app

@rjNemo
Copy link
Contributor

rjNemo commented Oct 9, 2022 •
edited

Hi @axel584, you also need to update the docs/fr/mkdocs.yml file to include the newly translated page

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

📝 Docs preview for commit 8658e0a at: https://634328d8d6cd7b5b90f491c9--fastapi.netlify.app

@axel584 axel584 mentioned this pull request Oct 10, 2022
Closed
9 tasks
@axel584
Copy link
Contributor Author

axel584 commented Oct 11, 2022

Le breaking change in the unit test will be resolve by this PR : #5456

@github-actions
Copy link
Contributor

📝 Docs preview for commit aa195d8 at: https://634668bcf6f89332a8126c53--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit aeb6243 at: https://6346797a4e841a37b7c34ede--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit a94bfa5 at: https://6346edeee15dea004f46d100--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 9efb26a at: https://6346f37f0775e9008d2e2df2--fastapi.netlify.app

@axel584 axel584 requested a review from rjNemo October 14, 2022 11:07
JulianMaurin
JulianMaurin reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@JulianMaurin JulianMaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small remarks (do not hesitate to challenge them) but this is nice 🙌
Thanks !

docs/fr/docs/advanced/additional-responses.md Outdated Show resolved Hide resolved
docs/fr/docs/advanced/additional-responses.md Show resolved Hide resolved
docs/fr/docs/advanced/additional-responses.md Show resolved Hide resolved
docs/fr/docs/advanced/additional-responses.md Show resolved Hide resolved
docs/fr/docs/advanced/additional-responses.md Outdated Show resolved Hide resolved
docs/fr/docs/advanced/additional-status-codes.md

Si vous renvoyez directement des codes HTTP et des réponses supplémentaires, ils ne seront pas inclus dans le schéma OpenAPI (la documentation de l'API), car FastAPI n'a aucun moyen de savoir à l'avance ce que vous allez renvoyer.

Mais vous pouvez documenter cela dans votre code, en utilisant : [Réponses supplémentaires dans OpenAPI](additional-responses.md){.internal-link target=_blank}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Mais vous pouvez documenter cela dans votre code, en utilisant : [Réponses supplémentaires dans OpenAPI](additional-responses.md){.internal-link target=_blank}.
Mais vous pouvez documenter cela dans votre code, en utilisant : [Reponses supplémentaires](additional-responses.md){.internal-link target=_blank}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you want to remove the "é" in "Réponses"... and I prefer use the whole title which specify "dans OpenAPI"...

axel584 and others added 2 commits October 15, 2022 08:06
@axel584 @JulianMaurin
Update docs/fr/docs/advanced/additional-responses.md
685ba9e 
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
@axel584 @JulianMaurin
Update docs/fr/docs/advanced/additional-responses.md
26deb29 
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 26deb29 at: https://634a4e93735def621336e05c--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit e05d84f at: https://634c4f9c83d30f3235e20306--fastapi.netlify.app

@axel584 axel584 removed the request for review from rjNemo October 19, 2022 09:10
@axel584 axel584 requested review from JulianMaurin and emmrichard and removed request for JulianMaurin October 19, 2022 09:10
@axel584 axel584 requested review from JulianMaurin and rjNemo and removed request for JulianMaurin October 25, 2022 20:53
@axel584 axel584 mentioned this pull request Oct 25, 2022
Closed
@axel584 axel584 mentioned this pull request Oct 31, 2022
Closed
9 tasks
@axel584
Copy link
Contributor Author

axel584 commented Nov 4, 2022

@JulianMaurin / @rjNemo : Does anyone know why my MR did not receive the "approved-2" label?

@tiangolo tiangolo added lang-all Translations awaiting-review lang-fr French translations labels Nov 4, 2022
@tiangolo tiangolo changed the title Add French translation for docs/fr/docs/advanced/additional-status-code.md 🌐 Add French translation for docs/fr/docs/advanced/additional-status-code.md Nov 13, 2022
@tiangolo
Copy link
Owner

Thank you @axel584! 🍰

And thanks for the reviews @JulianMaurin, @emmrichard, @rjNemo ☕

@tiangolo tiangolo enabled auto-merge (squash) November 13, 2022 14:00
@tiangolo tiangolo merged commit ba5310f into tiangolo:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianMaurin JulianMaurin JulianMaurin left review comments

@emmrichard emmrichard emmrichard approved these changes

@rjNemo rjNemo rjNemo approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-fr French translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@axel584 @rjNemo @tiangolo @emmrichard @JulianMaurin