Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Portuguese translation for docs/pt/docs/tutorial/response-status-code.md #4922

Merged

Conversation

batlopes
Copy link
Contributor

Added translation for pt to docs/pt/docs/tutorial/response-status-code.md

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (48367f4) compared to base (1213227).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4922   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       540           
  Lines        13934     13934           
=========================================
  Hits         13934     13934           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 56426f5 at: https://62840be46934081555609dd7--fastapi.netlify.app

@tiangolo tiangolo added lang-all Translations lang-pt Portuguese translations awaiting-review labels Jul 14, 2022
!!! info "Informação"
`status_code` também pode receber um `IntEnum`, como o do Python <a href="https://docs.python.org/3/library/http.html#http.HTTPStatus" class="external-link" target="_blank">`http.HTTPStatus`</a>.

Será:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dessa forma:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


Será:

* Retorne esse código de status na resposta.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este código de status será retornado na resposta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link

@julianofischer julianofischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi fellow.
In my opinion the text needs some modifications for clarity.

Será:

* Retorne esse código de status na resposta.
* Documente-o como tal no esquema OpenAPI (e, portanto, nas interfaces do usuário):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Será documentado como tal no esquema OpenAPI (e, portanto, nas interfaces do usuário):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -67,6 +67,8 @@ nav:
- tutorial/extra-data-types.md
- tutorial/query-params-str-validations.md
- tutorial/cookie-params.md
- tutorial/header-params.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with the translation!
Why have you added this line to mkdocs.yml? As far as I know the header params page is not translated yet hence it should not be added to this file yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I added it by mistake.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 48367f4 at: https://632cba418a107f0058df46b5--fastapi.netlify.app

@tiangolo tiangolo merged commit 146b9d6 into tiangolo:master Oct 31, 2022
@tiangolo
Copy link
Owner

Awesome, thanks a lot for the contribution @batlopes! 🙇

And thanks for the reviews @julianofischer, @jvmazagao, @Wuerike, @lsglucas! ☕ 🍰

@batlopes batlopes deleted the portuguese-translation/response-status-code branch November 2, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-pt Portuguese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants