Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Polish translation for docs/pl/docs/index.md #4245

Merged
merged 20 commits into from Jan 16, 2022

Conversation

MicroPanda123
Copy link
Contributor

Index.md to polish translation

docs/pl/docs/index.md Outdated Show resolved Hide resolved
docs/pl/docs/index.md Outdated Show resolved Hide resolved
docs/pl/docs/index.md Outdated Show resolved Hide resolved
docs/pl/docs/index.md Outdated Show resolved Hide resolved
docs/pl/docs/index.md Outdated Show resolved Hide resolved
docs/pl/docs/index.md Outdated Show resolved Hide resolved
docs/pl/docs/index.md Outdated Show resolved Hide resolved
docs/pl/docs/index.md Outdated Show resolved Hide resolved
docs/pl/docs/index.md Outdated Show resolved Hide resolved
docs/pl/docs/index.md Outdated Show resolved Hide resolved
@dutkiewicz
Copy link
Contributor

Fixed automatic translation to more grammatically correct with the Polish language

@tiangolo tiangolo changed the title index.md polish translation 🌐 Add Polish translation for docs/pl/docs/index.md Dec 8, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-pl Polish translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
MicroPanda123 and others added 15 commits December 8, 2021 16:00
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
@MicroPanda123
Copy link
Contributor Author

@dutkiewicz Thanks! Btw I know it seems like automatic but to be honest it wasn't, I just wanted to try doing translation and it didn't go very well heh. Thanks for changes, I appreciate it.

@dutkiewicz
Copy link
Contributor

No worries, that's the point of pull request reviews :) Ping me if you want to translate other docs

@bxsx
Copy link
Contributor

bxsx commented Dec 19, 2021

Hey @MicroPanda123
Just stumbled upon this PR and believe it still needs a lot of improvement (spelling, grammar, inaccurate terminology, etc.). Would you mind granting me write access to your fork? I can help with the translation, but there are too many issues here to play with GitHub suggestions. Thanks!

@MicroPanda123
Copy link
Contributor Author

Hey @bxsx, done, I gave you direct access, thanks for help! I appreciate it.

@bxsx
Copy link
Contributor

bxsx commented Dec 20, 2021

I've pushed f6159a8 with all my changes.

@MicroPanda123 @dutkiewicz would you like to take a look and approve (or suggest changes)?

@MicroPanda123
Copy link
Contributor Author

It looks good to me.

Copy link
Contributor

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my 2c: this translation is 10x better than no translation at all!

docs/pl/docs/index.md Show resolved Hide resolved
Co-authored-by: Dima Tisnek <dimaqq@gmail.com>
@@ -24,7 +24,7 @@

---

FastAPI to nowoczesny, wydajny framework webowy do budowania API z użyciem Pythona 3.6+ bazujący na standardowym typowaniu Pythona.
FastAPI to nowoczesny, wydajny framework webowy do budowania API z użyciem Pythona 3.6+ bazujący się na standardowym typowaniu Pythona.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I ran my suggestion by a native speaker and she says it should be framework ... bazujący na ... typowaniu. Without się.

So sorry I led you astray 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, mistakes happen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted

@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #4245 (98a8cf5) into master (58ab733) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #4245     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          409       498     +89     
  Lines        10264     12626   +2362     
===========================================
+ Hits         10264     12626   +2362     
Impacted Files Coverage Δ
fastapi/utils.py 100.00% <0.00%> (ø)
...test_tutorial/test_dataclasses/test_tutorial002.py 100.00% <0.00%> (ø)
..._tutorial/test_sql_databases/test_sql_databases.py 100.00% <0.00%> (ø)
...orial/test_sql_databases/test_testing_databases.py 100.00% <0.00%> (ø)
docs_src/app_testing/main_b.py
docs_src/app_testing/test_main_b.py
...torial/test_dependencies/test_tutorial001_py310.py 100.00% <0.00%> (ø)
docs_src/extra_data_types/tutorial001_py310.py 100.00% <0.00%> (ø)
...ts/test_tutorial/test_testing/test_main_b_py310.py 100.00% <0.00%> (ø)
docs_src/sql_databases/sql_app_py310/main.py 100.00% <0.00%> (ø)
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ab733...98a8cf5. Read the comment docs.

@tiangolo
Copy link
Owner

Thank you @MicroPanda123! 🚀

And thanks for all the help @bxsx, @dimaqq, and @dutkiewicz! 🙇 🍰

@tiangolo tiangolo enabled auto-merge (squash) January 16, 2022 19:36
@tiangolo tiangolo merged commit 5c5b889 into tiangolo:master Jan 16, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
Co-authored-by: Dawid Dutkiewicz <dutkiewicz@users.noreply.github.com>
Co-authored-by: Dima Tisnek <dimaqq@gmail.com>
Co-authored-by: Bart Skowron <bxsx@bartskowron.com>
Co-authored-by: Bart Skowron <bart.skowron@rollbar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-pl Polish translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants