Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for FrozenSet in parameters (e.g. query) #2938

Merged
merged 2 commits into from Aug 25, 2022

Conversation

juntatalor
Copy link
Contributor

@juntatalor juntatalor commented Mar 12, 2021

It was not possible to use frozenset in query params typing. This PR fixes/related to #2932

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #2938 (68d675c) into master (af3a6ef) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2938   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          534       534           
  Lines        13808     13811    +3     
=========================================
+ Hits         13808     13811    +3     
Impacted Files Coverage Δ
fastapi/dependencies/utils.py 100.00% <ø> (ø)
tests/test_application.py 100.00% <ø> (ø)
tests/test_query.py 100.00% <ø> (ø)
tests/main.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 54f9624 at: https://604b895678e8b113be7a476d--fastapi.netlify.app

@theo-brown
Copy link

Hi there, it looks like this hasn't been merged yet?

@tiangolo tiangolo changed the title fix: allow using FrozenSet in query params #2932 ✨ Add support for FrozenSet in parameters (e.g. query) Aug 25, 2022
@github-actions
Copy link
Contributor

📝 Docs preview for commit 68d675c at: https://6307eedaec89f500a06b1e72--fastapi.netlify.app

@tiangolo
Copy link
Owner

Awesome, thank you @juntatalor! 🚀

And thanks for the reviews @Mause and @as24-asingla 🍰

@tiangolo tiangolo merged commit ca2fae0 into tiangolo:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants