Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ Add support for Python 3.9 #2298

Merged
merged 5 commits into from Aug 2, 2021

Conversation

Kludex
Copy link
Sponsor Collaborator

@Kludex Kludex commented Nov 4, 2020

Pydantic added support to Python 3.9 last week on this PR.

TODO:

  • Add tests with the new typing feature i.e. dict[int]

Notes:

  • I haven't talked to @tiangolo about this PR and I don't know his wishes towards this support. Please, do not assume this will be merged.
  • Parametrize was not possible in the tests due to incompatibility of notation on Python versions and the fact that Pytest gets to discover the code even if the skipif mark is used.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #2298 (e37ad3d) into master (e9ba01d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2298   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          408       409    +1     
  Lines        10229     10244   +15     
=========================================
+ Hits         10229     10244   +15     
Impacted Files Coverage Δ
..._sql_databases_peewee/test_sql_databases_peewee.py 100.00% <100.00%> (ø)
tests/test_typing_python39.py 100.00% <100.00%> (ø)
tests/test_union_inherited_body.py 100.00% <100.00%> (ø)
fastapi/utils.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9ba01d...e37ad3d. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

📝 Docs preview for commit 5669a2b at: https://5fa32e2b16c730102e69945a--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

📝 Docs preview for commit 7f329e2 at: https://5fa33361d0bdc30c81f6f47d--fastapi.netlify.app

@Kludex Kludex marked this pull request as ready for review November 5, 2020 00:49
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2020

📝 Docs preview for commit cbdd4b9 at: https://5fa34c5e0b2657362e5b83f1--fastapi.netlify.app

@tiangolo
Copy link
Owner

tiangolo commented Nov 5, 2020

This is awesome! 🚀 I'm gonna check it in detail thoroughly later, I was actually expecting a lot of internal changes to support it 😅

@Kludex Kludex mentioned this pull request May 7, 2021
6 tasks
@Kludex Kludex mentioned this pull request Jul 20, 2021
@tiangolo tiangolo changed the title feat: support python 3.9 ⬆ Add support for Python 3.9 Aug 2, 2021
@tiangolo tiangolo merged commit ab33ba2 into tiangolo:master Aug 2, 2021
@tiangolo
Copy link
Owner

tiangolo commented Aug 2, 2021

Great, thanks @Kludex! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants